Skip to content

🐛 [Frontend] Fix: storage/async-jobs was retired #7429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 26, 2025
Merged

🐛 [Frontend] Fix: storage/async-jobs was retired #7429

merged 12 commits into from
Mar 26, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 26, 2025 •
edited
Loading

What do these changes do?

In this PR some breaking changes were introduced. This PR catches up and replaces the storage/async-jobs calls with the already in place tasks

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Mar 26, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected and removed t:enhancement Improvement or request on an existing feature labels Mar 26, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 26, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 26, 2025 09:19
GitHK
GitHK approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that in the backend they are still used but for the frontend they expose the same interface as the exiting ones?

sanderegg
sanderegg approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 26, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Mar 26, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d0d22ce

@codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (a6d85cc) to head (b509e8d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7429      +/-   ##
==========================================
- Coverage   87.43%   87.35%   -0.08%     
==========================================
  Files        1652     1707      +55     
  Lines       63997    66412    +2415     
  Branches     1131     1131              
==========================================
+ Hits        55958    58017    +2059     
- Misses       7717     8073     +356     
  Partials      322      322
Flag Coverage Δ
integrationtests 65.17% <ø> (ø)
unittests 86.53% <ø> (-0.05%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.05% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 73.02% <ø> (ø)
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <ø> (-0.10%) ⬇️
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (-0.11%) ⬇️
storage 84.29% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.73% <ø> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d85cc...b509e8d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit d0d22ce into ITISFoundation:master Mar 26, 2025
95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

4 participants

@odeimaiz @GitHK @pcrespov @sanderegg